feat : convert --function flag data to selector #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
changed the title
sslivkoff
requested changes
Dec 26, 2023
crates/cli/src/args.rs
Outdated
| @@ -260,9 +261,26 @@ pub struct Args { | |||
| /// Event signature for log decoding | |||
| #[arg(long, value_name = "tracer", help_heading = "Dataset-specific Options")] | |||
| pub js_tracer: Option<String>, | |||
| /// Keep raw decoded columns like topic0, topic1, etc. | |||
| #[arg(long, help_heading = "Output Options")] | |||
| pub keep_raw_decoded: bool, | |||
There was a problem hiding this comment.
wrong PR?
hmmmm i'm not sure why this is here, i don't remember have written this, sorry btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when user pass function with --function args we need to convert this to selector