Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bundle diff report #63

Closed
wants to merge 1 commit into from
Closed

Conversation

dalechyn
Copy link
Contributor

@dalechyn dalechyn commented Apr 5, 2023

Closes #58

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flux ✅ Ready (Inspect) Visit Preview Apr 5, 2023 7:24pm

@pr-codex
Copy link

pr-codex bot commented Apr 5, 2023

Tldr

Added a Github action for bundle size comparison and added new packages including rollup-plugin-visualizer.

Detailed summary

  • Added a new Github action bundle-diff.yml for bundle size comparison.
  • Added rollup-plugin-visualizer package.
  • Updated package-lock.json with new packages:
    • ansi-regex v5.0.1
    • cliui v8.0.1
    • define-lazy-prop v2.0.0
    • emoji-regex v8.0.0
    • escalade v3.1.1
    • get-caller-file v2.0.5
    • is-docker v2.2.1
    • is-fullwidth-code-point v3.0.0
    • is-wsl v2.2.0
    • open v8.4.2.

@@ -0,0 +1,106 @@
name: Bundle diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just put this all under the previous build one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed we can. But as I mentioned in the linked issue, the pipeline does not work unfortunately, since there is no tool that can gather a rollup diff.

@transmissions11
Copy link
Member

transmissions11 commented Apr 29, 2023

hmmm gonna close this for now as there doesn't seem to be a good solution yet - appreciate your efforts in getting this far tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: github plugin that shows bundle size diff on every PR
2 participants