feat(trie): sparse trie leaf removal #11752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
16ede41
to
a4fbfa7
Compare
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
d420915
to
7591030
Compare
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
f51d7a6
to
6592ae9
Compare
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
09b87fd
to
cad2dce
Compare
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
c02edf1
to
684e452
Compare
rkrasiuk
reviewed
Oct 15, 2024
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
c531954
to
f15b063
Compare
shekhirin
force-pushed
the
alexey/sparse-trie-remove
branch
from
d313383
to
b8346ba
Compare
rkrasiuk
requested changes
Oct 16, 2024
Comment on lines
+280
to
+283
|
|
||
| // Walk the stack of removed nodes from the back and re-insert them back into the trie, | ||
| // adjusting the node type as needed. | ||
| while let Some(removed_node) = removed_nodes.pop() { |
There was a problem hiding this comment.
the leaf node might also be the root. then removed_nodes is empty and we violate the invariant that the trie always contains the root node. would be great to add a test for this too
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11743
Blocked by alloy-rs/trie#58