Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade proc-macro2 package #688

Merged

Conversation

tgonzalezorlandoarm
Copy link
Member

proc-macro2 introduces a regression that breaks our Nightly Checks on rust nightly builds that are post nightly-2023-06-27, as explained in this issue.

Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

Our CI's Nightly Checks are failing with 'unknown feature
`proc_macro_span_shrink`' error. This problem is explained in
rust-lang/rust#113152.

As mentioned in
rust-lang/rust#113152 (comment)
the issue may be solved by updating proc-macro2 to version 1.0.60+

Run 'cargo update --package proc-macro2' to fix the issue.

Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
@gowthamsk-arm gowthamsk-arm merged commit 51c707b into parallaxsecond:main Jul 31, 2023
13 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/upgrade-proc-macro branch September 11, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants