Use Rust version 1.60.0 when building for coverage in the CI #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-tarpaulin needs at least Rust 1.60.0 to compile with a version that is newer than two years old. The version is fixed to 0.24.0 because newer versions need at least Rust 1.64.0. * To provide coverage with an up-to-date tool, use Rust 1.60.0 for the coverage build in ci.sh. * Fix the cargo-tarpaulin version to 0.24.0. This one should be upgraded when the coverage build is upgraded as well. Signed-off-by: Tomás González <[email protected]>
|
@ionut-arm @gowthamsk-arm Could I get some input as to whether this is a good idea or whether there is a different approach that I should take? |
|
This would fix all Nightly issues |
tgonzalezorlandoarm
changed the title
|
Closing this PR as #692 is opened now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-tarpaulin needs at least Rust 1.60.0 to compile with a version that is newer than two years old. The version is fixed to 0.24.0 because newer versions need at least Rust 1.64.0.