Add function name to errors and logs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ionut-arm it seems this is largely OK to merge (after fixing conflicts). Is there anything else you'd like to add to it? |
ionut-arm
force-pushed
the
fn-in-error-2
branch
from
16964d4
to
1d605a1
Compare
ionut-arm
force-pushed
the
fn-in-error-2
branch
from
1d605a1
to
77d046a
Compare
Ok, I've incorporated your feedback, I don't think I can easily avoid breaking the interface since we rely on enums for errors.. |
Adding the name of the function that lead to a backend error to the log messages it generates and to the error returned to the client. Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
fn-in-error-2
branch
from
77d046a
to
43b76e8
Compare
wiktor-k
approved these changes
Nov 29, 2023
gowthamsk-arm
approved these changes
Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the name of the function that lead to a backend error to the log messages it generates and to the error returned to the client.
cc @ellerh