Fix cargo test compilation
#539
Conversation
Signed-off-by: Travis Finkenauer <[email protected]>
optional dependencies are implicitly features Signed-off-by: Travis Finkenauer <[email protected]>
Signed-off-by: Travis Finkenauer <[email protected]>
|
This is related to the #538 . Normally when I build the tests I just specify all features because I want to build everything but I think it is not very intuitive to have to specify features you do not even know exists when building. So I would really like for all features to be default. So in the PR I mentioned I suggested to change to resolver 2 to specify the features in dev-depedencies. And hopefully make all this markup unnecessary. So it would be nice to see a PR that tries to solve the problem using the suggested method in 538 pr. |
This PR builds upon the work made in parallaxsecond#539 and parallaxsecond#538 and fixes a problem with running tests required several features to be specified in order for the tests to compile. This has been accomplish by doing the following: 1. Tests have been refactored in order to avoid dependency on features that may and may not be available. 2. Updated workspace Cargo.toml to use version 2 resolver. 3. Updated tss-esapi Cargo.toml to use the crate it self as dev-dependency with most of the features enabled. Co-authored-by: Travis Finkenauer <[email protected]> Co-authored-by: William Brown <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
This PR builds upon the work made in parallaxsecond#539 and parallaxsecond#538 and fixes a problem with running tests required several features to be specified in order for the tests to compile. This has been accomplish by doing the following: 1. Tests have been refactored in order to avoid dependency on features that may and may not be available. 2. Updated workspace Cargo.toml to use version 2 resolver. 3. Updated tss-esapi Cargo.toml to use the crate it self as dev-dependency with most of the features enabled. Co-authored-by: Travis Finkenauer <[email protected]> Co-authored-by: William Brown <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
|
This issue has been resolved in #543. I added you as co-author on that PR hope that works for you. I'll be closing this PR. |
Sure--no worries. |
If "serde" or "abstraction" features were not set, then the tests would not compile