Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in the build process / treat as errors #155

Closed
wants to merge 1 commit into from

Conversation

tcptomato
Copy link

People are starting to commit code for which the compiler gives warnings. This can be dangerous as it might hide bugs, and could break the code in the future. The solution to this problem is the -Werror compiler flag, which treats warnings as errors.

This pull request shouldn't be merged atm, as it will break the build process. I created it more to start a discussion on this topic.

Changes.
Modified readme and the travis configuration file as to treat warnings as errors.

@WesleyCeraso
Copy link
Contributor

Why do not merge? I think it should be to enforce the no-warning policy.

@tcptomato
Copy link
Author

Because as is, it will break the build process. ( This is why Travis says the build for this commit failed :) )

@olajep
Copy link
Member

olajep commented Jun 17, 2015

Pushed compiler warning fixes. Can you rebase on master so we can see if it passes on travis too?

Thanks,
Ola

@tcptomato
Copy link
Author

I rebased it on master. Which is 3 commits behind upstream/master. But when I add as a remote to get the changes, I get a permission denied on the git fetch. Gtg now, will debug later.

@tcptomato tcptomato closed this Jun 22, 2015
@tcptomato
Copy link
Author

Added latest changes from upstream. See pull request #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants