-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dfyn v2 #401
Open
RahulBane08
wants to merge
49
commits into
paraswap:master
Choose a base branch
from
dfyn:dfyn-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dfyn v2 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
Added Price Computation And Swap Events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
In this pull request, our focus has been on implementing the quote fetching logic for Dfyn-V2 integration.
To fetch quotes, we have utilized the Price Computation Function, Swap events, and aggregated RPC calls. In addition, we have seamlessly integrated our subgraph to retrieve the Top Liquidity Pools for a specific token or pair.
For the multiSwap and megaSwap functionalities, it will be necessary to add Adaptors that are compatible with DfynV2 in the contracts, as the payload structure differs from the available dex options.
We welcome any feedback and suggestions for improvements on the code base provided in this pull request.
For detailed information and reference, please find the attached document that includes the Adapter parameter details for DfynV2, as well as the addresses of all live contracts and the Dfyn-V2 development book.
Thank you for your attention and support.
Link: https://docs.google.com/document/d/19V5CEEkzO5mWboVIfGLB9CAtgg6BD0TMXZNnQsETsjs/edit?usp=sharing