build: reintroduce snap packaging, test, and release flows #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
commented
Aug 13, 2024
|
|
||
| - name: Release to latest/edge | ||
| env: | ||
| SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }} |
There was a problem hiding this comment.
We need to make sure this is still set - though I'm guessing it's probably still in the secrets config for the repo
brancz
approved these changes
Aug 14, 2024
|
Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the snap package, and the test/release workflow.
Unfortunately, we cannot use the plain
goreleasersetup for building/releasing the snap, as the project is currently using a Goreleaser Docker image, which is unable to runsnapcraft.That said, it makes this job slightly easier, as much of what was in place before will still work. There are a couple of places where we might need to tweak artifact paths and suchlike, but otherwise this should work.
@brancz - at the moment I've tagged on the snap build, and test, and release into one workflow to avoid too much duplication, but we can adjust if you'd prefer.