goreleaser: Don't prefix docker image with v #2972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version should have the v as part of the name for a release.
metalmatze
force-pushed
the
goreleaser-docker-version
branch
from
03740d9
to
d12fff4
Compare
|
Hey @jnsgruk, the builds are failing for snap. What is the best way to resolve this for snaps? |
kakkoyun
approved these changes
Aug 27, 2024
It's because I've got snapcraft.yaml to grab the version from the manifest, which in this case is a big long string. See https://github.com/parca-dev/parca-agent/blob/main/snap/snapcraft.yaml#L34-L35 It should be safe to merge, in that it'll work fine for actual releases - I can try and make the logic a bit cleverer so it just uses the short hash as the version in cases where the commit isn't tagged at some point |
|
Other option is to have goreleaser configured to do neater versions for unreleased stuff like "0.32.0-next" or "0.34.1-deadbeef" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version should have the v as part of the name for a release.
Additionally renaming the deprecated name_template to version_template.