Point to latest version of our otel profiler fork #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet -- it's not uploading any profiles when I run it locally; something must be wrong. |
You now need to call `StartRealtimeSync` on startup, or the reported timestamps will be relative to system boot time, rather than to the Unix epoch.
|
Now ready for a look. |
brancz
approved these changes
Sep 2, 2024
reporter/parca_reporter.go
Outdated
| @@ -244,7 +241,9 @@ func (r *ParcaReporter) ExecutableMetadata(ctx context.Context, | |||
| } | |||
|
|
|||
| // Always attempt to upload, the uploader is responsible for deduplication. | |||
| r.uploader.Upload(ctx, fileID, buildID, open) | |||
| // !! FIXME !! Apparently uploading stuff in this function is a "really bad idea"; | |||
| // see https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/126#pullrequestreview-2248554710 | |||
There was a problem hiding this comment.
The recommendation is to specifically not block this Go routine, but instead open the file and pass the file handle to an asynchronous mechanism. Apart from immediately opening the file, that's exactly how our mechanism works, so we can remove the context here without a problem.
umanwizard
commented
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several innocuous changes, but please take a look at the comment beginning
!! FIXME !!. We will have to address that soon, I think.