Sort assets before splitting for unstable MSBs

[AGawrys]

↪️ Pull Request

Sort Manual Shared Bundle assets before splitting. Should we sort based on a different property or is localeCompare(assets.id) good enough?

Note this didn't change the order of assets in our test case.

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.51s	-142.00ms 🚀
Cached	261.00ms	-47.00ms 🚀

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	253.00ms	-29.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	261.00ms	-28.00ms 🚀
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	261.00ms	-27.00ms 🚀
dist/legacy/index.ff03421b.js	1.48kb	+0.00b	374.00ms	-76.00ms 🚀
dist/legacy/index.e9bb1616.js	1.06kb	+0.00b	374.00ms	-75.00ms 🚀
dist/modern/index.4a29d309.js	921.00b	+0.00b	374.00ms	-74.00ms 🚀
dist/legacy/index.html	826.00b	+0.00b	408.00ms	-95.00ms 🚀
dist/modern/index.html	749.00b	+0.00b	406.00ms	-96.00ms 🚀
dist/legacy/index.b8ae99ba.css	94.00b	+0.00b	277.00ms	-17.00ms 🚀
dist/modern/index.31cedca9.css	94.00b	+0.00b	276.00ms	-17.00ms 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/index.ff03421b.js	1.48kb	+0.00b	429.00ms	+47.00ms ⚠️
dist/legacy/index.e9bb1616.js	1.06kb	+0.00b	429.00ms	+47.00ms ⚠️
dist/modern/index.4a29d309.js	921.00b	+0.00b	429.00ms	+47.00ms ⚠️

React HackerNews ✅

Timings

Description	Time	Difference
Cold	4.04s	-188.00ms
Cached	418.00ms	+23.00ms ⚠️

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/index.js	459.11kb	+0.00b	1.00s	-62.00ms 🚀
dist/PermalinkedComment.e9dc4a75.js	3.92kb	+0.00b	327.00ms	-52.00ms 🚀
dist/UserProfile.8945a243.js	1.38kb	+0.00b	327.00ms	-52.00ms 🚀
dist/NotFound.8b44a81d.js	269.00b	+0.00b	327.00ms	-52.00ms 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/logo.8dd07848.png	244.00b	+0.00b	263.00ms	-25.00ms 🚀

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	35.09s	+24.00ms
Cached	2.27s	-103.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/media-viewer.38e3999a.js	536.13kb	+0.00b	11.39s	-848.00ms 🚀
dist/ConfigPanelFieldsLoader.182d39bc.js	303.43kb	+0.00b	10.78s	+2.22s ⚠️
dist/card.d06de810.js	138.91kb	+0.00b	10.78s	+2.22s ⚠️
dist/ElementBrowser.e8f01080.js	61.94kb	+0.00b	10.78s	+2.22s ⚠️
dist/esm.bfca2115.js	59.30kb	+0.00b	10.78s	+2.22s ⚠️
dist/component-lazy.51d1dec9.js	58.94kb	+0.00b	5.33s	-812.00ms 🚀
dist/ConfigPanelFieldsLoader.2b7c03be.js	15.74kb	+0.00b	10.78s	+2.22s ⚠️
dist/ui.8c117104.js	14.48kb	+0.00b	10.78s	+2.22s ⚠️
dist/ConfigPanelFieldsLoader.5dfde67d.js	13.63kb	+0.00b	10.78s	+2.22s ⚠️
dist/pdfRenderer.01deafa1.js	12.04kb	+0.00b	10.78s	+2.22s ⚠️
dist/mobile-upload.3baad8e4.js	7.79kb	+0.00b	10.78s	+2.22s ⚠️
dist/mobile-upload.7a892a37.js	7.79kb	+0.00b	10.78s	+2.22s ⚠️
dist/codeViewerRenderer.51140ec8.js	2.61kb	+0.00b	10.78s	+2.22s ⚠️
dist/zh_TW.b7c55aa6.js	1.86kb	+0.00b	10.78s	+2.22s ⚠️
dist/zh.b01fe721.js	1.84kb	+0.00b	10.78s	+2.22s ⚠️
dist/workerHasher.540c9790.js	1.56kb	+0.00b	10.78s	+2.22s ⚠️
dist/workerHasher.c840c607.js	1.56kb	+0.00b	10.78s	+2.22s ⚠️
dist/heading4.be08fc9e.js	1.12kb	+0.00b	5.33s	-812.00ms 🚀
dist/simpleHasher.c14e20b4.js	589.00b	+0.00b	10.78s	+2.22s ⚠️
dist/simpleHasher.23db7a52.js	589.00b	+0.00b	10.78s	+2.22s ⚠️

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/media-viewer.38e3999a.js	536.13kb	+0.00b	8.40s	-3.18s 🚀
dist/mobile-upload.f21df36e.js	66.34kb	+0.00b	4.93s	-287.00ms 🚀
dist/component.a781cbb6.js	57.16kb	+0.00b	4.93s	-279.00ms 🚀
dist/Modal.38d9f78c.js	27.83kb	+0.00b	4.93s	-279.00ms 🚀
dist/component.c2c7f470.js	18.68kb	+0.00b	4.93s	-279.00ms 🚀
dist/js.e1035d4d.js	17.15kb	+0.00b	4.93s	-287.00ms 🚀
dist/mobile-upload.3747b689.js	7.79kb	+0.00b	4.93s	-276.00ms 🚀
dist/Modal.850345b4.js	3.86kb	+0.00b	4.93s	-276.00ms 🚀
dist/component.360dba95.js	3.20kb	+0.00b	4.93s	-276.00ms 🚀
dist/png-chunks-extract.92497b2d.js	3.06kb	+0.00b	4.93s	-287.00ms 🚀
dist/codeViewerRenderer.51140ec8.js	2.61kb	+0.00b	8.37s	-3.21s 🚀
dist/workerHasher.4f6584da.js	1.56kb	+0.00b	4.93s	-287.00ms 🚀
dist/16.4998f52b.js	1.35kb	+0.00b	4.94s	-279.00ms 🚀
dist/16.330880f6.js	1.29kb	+0.00b	4.93s	-280.00ms 🚀
dist/16.371e251f.js	1.00kb	+0.00b	4.93s	-279.00ms 🚀
dist/16.8adad466.js	980.00b	+0.00b	4.94s	-278.00ms 🚀
dist/16.71432140.js	980.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.e5f05248.js	960.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.79864de1.js	920.00b	+0.00b	4.94s	-285.00ms 🚀
dist/16.7d7d7930.js	862.00b	+0.00b	4.93s	-285.00ms 🚀
dist/16.4556c00f.js	834.00b	+0.00b	4.93s	-285.00ms 🚀
dist/16.a44bb474.js	827.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.dffb58fe.js	782.00b	+0.00b	4.93s	-280.00ms 🚀
dist/16.0118b1f8.js	776.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.9a311f76.js	776.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.edf70d70.js	775.00b	+0.00b	4.93s	-280.00ms 🚀
dist/16.4af9f37f.js	774.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.aa70dcce.js	773.00b	+0.00b	4.93s	-278.00ms 🚀
dist/16.54ffa2b2.js	725.00b	+0.00b	4.93s	-279.00ms 🚀
dist/16.d7c3881b.js	697.00b	+0.00b	4.94s	-285.00ms 🚀
dist/simpleHasher.09765db3.js	589.00b	+0.00b	4.93s	-276.00ms 🚀
dist/ro.8d5b380a.js	482.00b	+0.00b	5.95s	-2.23s 🚀
dist/index.html	248.00b	+0.00b	8.03s	-3.73s 🚀

Three.js ✅

Timings

Description	Time	Difference
Cold	2.99s	+34.00ms
Cached	364.00ms	+35.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.