Upstream some REPL changes #9328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
force-pushed
the
repl-upstream
branch
from
06a866f to
ebce7d8
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. |
mischnic
force-pushed
the
repl-upstream
branch
4 times, most recently
from
2d5cc41 to
f8e2854
Compare
mischnic
force-pushed
the
repl-upstream
branch
from
f8e2854 to
5b14027
Compare
devongovett
reviewed
Nov 7, 2023
| format === 'ansi' | ||
| ? _chalk | ||
| : { | ||
| gray: { |
There was a problem hiding this comment.
is gray the only color we use?
There was a problem hiding this comment.
Yes, gray underline is the only thing used in this function (and if not, Flow would complain as well).
The remaining colors of printed diagnostics come from the function that formats the result of prettyDiagnostic (like the CLI reporter), and from the codeframe syntax highlighter.
The latter is currently not working in the REPL because by default chalk is a noop in the browser, unless force-enabled with an option. The syntax highlighter emphasize only exposes these chalk options in newer versions, which are ESM only. That would work fine for the published Parcel packages (@parcel/codeframe is bundled before publishing), but not in the monorepo where @parcel/codeframe is only transpiled with Babel and resulting in require("emphasize").
mischnic
commented
Nov 7, 2023
| worker.on('ready', () => { | ||
| this.readyWorkers++; | ||
| if (this.readyWorkers === this.options.maxConcurrentWorkers) { | ||
| this.emit('ready'); |
There was a problem hiding this comment.
This new ready event on the WorkerFarm is used to show in the REPL UI when the workers are ready (the slow bit is loading the JS/Wasm)
|
I added a message to signal the main thread when the worker is started, and a message to signal the worker it's about to be |
devongovett
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/, which usually never happens.makeShared, only copy contents if the buffer isn't empty (caused some strange errors likecannot perform TypedArray.prototype.set for detached buffer)process.stdoutis undefined on webchild_process.execis undefined on web