Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env.supports to match browserslist for es6-modules etc. #9762

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

rmmh
Copy link

@rmmh rmmh commented Jun 3, 2024

↪️ Pull Request

Fix env.supports to match browserslist for es6-modules etc.

Critically, this ensures that a browserslist of "supports es6-modules" will not produce differential bundling <script nomodule> tags.

Minimum supported browser versions are largely sourced from caniuse.com, plus some data pulled from old user agent strings for the Chromium clones.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

Critically, this ensures that a browserslist of "supports es6-modules"
will *not* produce differential bundling <script nomodule> tags.

Minimum supported browser versions are largely sourced from caniuse.com,
plus some data pulled from old user agent strings for the Chromium clones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant