Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manual Shared Bundle Blurb to Code splitting doc #1099

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

AGawrys
Copy link
Contributor

@AGawrys AGawrys commented Dec 14, 2023

Adds documentation on how to use the manualSharedBundles config option for the DefaultBundler. Includes some common reasons why a project may benefit from MSB (manual Shared Bundles), as well as a basic example of how to add config to your package.json

This PR should be merged once the Source Bundles Property PR is merged. That PR renames parentAsset to root, the property that specifies what file should be targeted by the assets glob.

It also adds a loadedBy optional config, which allows users to specify bundleRoots that will use this MSB (manual shared bundle)

Notes

Note that "display rich diff" in Github does not support all formatting used, here's a screen grab of what the page will look like:

experimental_msb_blurb

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 6:40pm

@devongovett
Copy link
Member

Updated to remove loadedBy for now since that PR isn't merged yet, and re-worded a bit for clarity.

@devongovett devongovett merged commit 50d63e6 into v2 Feb 28, 2024
2 checks passed
@devongovett devongovett deleted the agawrys/unstable-manual-bundles-blurb branch February 28, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants