Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed-hash: remove rustc-hex feature #873

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed-hash: remove rustc-hex feature #873

wants to merge 3 commits into from

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Oct 8, 2024 •
edited
Loading

merge #872 first

  • remove rustc-hex feature (rustc-hex is only used for std::str::FromStr impl, so I don't think the feature is necessary)
  • use const-hex instead of rustc-hex dependency (rustc-hex is no longer maintained, and const-hex has better performance)

BTW, I'm considering replacing both hex and rustc-hex in dependency tree with const-hex.

@koushiro koushiro requested a review from a team as a code owner October 8, 2024 17:15
@ordian ordian added breaking-change Breaking change changelog Needs to be added to the changelog labels Oct 9, 2024
@koushiro
Copy link
Contributor Author

@ordian @bkchr PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change Breaking change changelog Needs to be added to the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushiro @ordian