-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoOp Impl Polling Trait #5311
Open
Doordashcon
wants to merge
14
commits into
paritytech:master
Choose a base branch
from
Doordashcon:Polling-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+301
−150
Open
NoOp Impl Polling Trait #5311
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1eedd89
salary & core-fellowship
Doordashcon 0e300cf
Merge branch 'master' into Polling-impl
Doordashcon 4304153
Skip None Poll::classes()
Doordashcon fef9f08
adds pr docs
Doordashcon 0efc3bd
Merge branch 'master' into Polling-impl
Doordashcon 15512b1
NoOp unit
Doordashcon 9167e7a
fmt
Doordashcon d2fc8b1
remove imports
Doordashcon 23c2983
vec::Vec
Doordashcon 63a4bfa
Default Poll Classes
Doordashcon c9460f6
update pr doc
Doordashcon 6f1bbeb
nit
Doordashcon ec8598e
NoOp benchmark inclusion
Doordashcon 387c00e
not a function
Doordashcon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
title: No-op Impl Polling Trait | ||
|
||
doc: | ||
- audience: Runtime Dev | ||
description: | | ||
Provide a NoOp implementation of the Polling trait for unit where the trait is defined and skiping benchmarks that necessitate it's definition. | ||
|
||
crates: | ||
- name: pallet-core-fellowship | ||
bump: minor | ||
- name: pallet-ranked-collective | ||
bump: minor | ||
- name: pallet-salary | ||
bump: minor | ||
- name: frame-support | ||
bump: minor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what weight
Skip
will result?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Secretary Collective requires skipping these extrinsics to generate weights for the ranked_collective pallet instance which uses this NoOp implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I have not checked the actual code, what we need to do here if
classes()
returns nothing, we need to pass some invalid poll index. The function is still trying to access the storage etc.