[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

alvicsam · 2024-09-11T10:27:00Z

cc https://github.com/paritytech/ci_cd/issues/1035

close https://github.com/paritytech/ci_cd/issues/1023

alvicsam · 2024-09-11T10:29:50Z

/cmd help

github-actions · 2024-09-11T10:31:41Z

Command "help" has started 🚀 See logs here

github-actions · 2024-09-11T10:31:54Z

Command "help" has failed ❌! See logs here

alvicsam · 2024-09-11T10:32:08Z

bot fmt

command-bot · 2024-09-11T10:32:14Z

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-f635b668-ec61-4fba-8c53-6d0873da4411 to cancel this command or bot cancel to cancel all commands in this pull request.

alvicsam · 2024-09-11T10:34:09Z

bot help

command-bot · 2024-09-11T10:34:09Z

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086/artifacts/download.

command-bot · 2024-09-11T10:34:13Z

Here's a link to docs

alvicsam · 2024-09-11T10:35:00Z

bot -v CMD_IMAGE=docker.io/paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 fmt

command-bot · 2024-09-11T10:35:05Z

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-69c20856-38ce-4cb3-90f3-359d2f53dde3 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-11T10:36:37Z

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088/artifacts/download.

alvicsam · 2024-09-11T10:39:32Z

bot update-ui latest --rust_version=1.81

command-bot · 2024-09-11T10:39:37Z

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-ab4bc0bc-095e-4f2b-8ae0-24b6a3628629 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-11T10:40:52Z

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182/artifacts/download.

alvicsam · 2024-09-11T11:52:54Z

@ggwpez could you please help with the CI errors (tests, clippy)?

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2024-09-11T13:34:48Z

@gui1117 i applied your fix here, just FYI

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

bkchr · 2024-09-18T16:19:51Z

bridges/relays/messages/src/message_race_loop.rs

@@ -226,13 +226,16 @@ pub trait RaceState<SourceHeaderId, TargetHeaderId>: Clone + Send + Sync {
 	fn set_best_finalized_source_header_id_at_best_target(&mut self, id: SourceHeaderId);

 	/// Best finalized source header id at the source client.
+	#[allow(dead_code)]


Is this trait not public outside of this module? We should remove this code then.

bkchr · 2024-09-18T16:20:18Z

bridges/relays/messages/src/message_race_limits.rs

@@ -39,15 +39,19 @@ pub struct RelayReference<
 	TargetClient: MessageLaneTargetClient<P>,
 > {
 	/// The client that is connected to the message lane source node.
+	#[allow(dead_code)] // FAIL-CI


What is about this?

bkchr · 2024-09-18T18:07:18Z

polkadot/xcm/xcm-executor/src/traits/weight.rs

@@ -31,6 +31,7 @@ pub trait WeightBounds<RuntimeCall> {

 /// A means of getting approximate weight consumption for a given destination message executor and a
 /// message.
+#[allow(dead_code)]


Why is this dead code? Is the trait not reachable form the outside? Then we should remove it.

bkchr · 2024-09-18T18:10:39Z

substrate/client/network/src/protocol/notifications/handler.rs

@@ -282,6 +282,7 @@ pub enum NotifsHandlerOut {
 		/// Name of the protocol that was actually negotiated, if the default one wasn't available.
 		negotiated_fallback: Option<ProtocolName>,
 		/// The endpoint of the connection that is open for custom protocols.
+		#[allow(dead_code)]


bkchr · 2024-09-18T18:11:10Z

substrate/client/network/src/protocol/notifications/upgrade/notifications.rs

@@ -193,6 +193,7 @@ pub struct NotificationsInOpen<TSubstream> {
 	pub handshake: Vec<u8>,
 	/// If the negotiated name is not the "main" protocol name but a fallback, contains the
 	/// name of the negotiated fallback.
+	#[allow(dead_code)]


bkchr · 2024-09-18T18:30:34Z

substrate/primitives/state-machine/src/ext.rs

@@ -713,6 +713,7 @@ where
 }

 /// Implement `Encode` by forwarding the stored raw vec.
+#[allow(dead_code)]


Suggested change

#[allow(dead_code)]

#[cfg(any(test, feature = "fuzzing"))]

It is still used in two log statements, so guarding it with test and fuzzing wont work.

bkchr · 2024-09-18T18:30:41Z

substrate/primitives/state-machine/src/ext.rs

@@ -713,6 +713,7 @@ where
 }

 /// Implement `Encode` by forwarding the stored raw vec.
+#[allow(dead_code)]
 struct EncodeOpaqueValue(Vec<u8>);

 impl Encode for EncodeOpaqueValue {


Suggested change

impl Encode for EncodeOpaqueValue {

#[cfg(any(test, feature = "fuzzing"))]

impl Encode for EncodeOpaqueValue {

substrate/utils/frame/benchmarking-cli/build.rs

substrate/utils/wasm-builder/src/wasm_project.rs

Co-authored-by: Bastian Köcher <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Clippy otherwise reports a duplicated trait bound and is unhappy about that. Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2024-09-19T22:29:06Z

Something in the orchestrator crate seems to emit code that trigger clippy:

error: trait `OrchestraFieldState` is never used
     --> /__w/polkadot-sdk/polkadot-sdk/target/debug/build/expander-f21e58b59c39b7b5/out/orchestra-expansion-d13355006895.rs:14155:7
      |
14155 | trait OrchestraFieldState<T> {}
      |       ^^^^^^^^^^^^^^^^^^^
      |
      = note: `-D dead-code` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(dead_code)]`

    Rustc finished with error: exit status 1
error: could not compile `polkadot-overseer` (lib) due to 1 previous error

[ci] Update CI image with rust 1.81.0 and 2024-09-11

195f96f

alvicsam requested review from a team as code owners September 11, 2024 10:27

alvicsam added the R0-silent Changes should not be mentioned in any release notes label Sep 11, 2024

".git/.scripts/commands/fmt/fmt.sh"

7460c42

paritytech-ci requested review from a team and koute as code owners September 11, 2024 10:36

paritytech-review-bot bot requested a review from a team September 11, 2024 10:37

mordamax and others added 3 commits September 11, 2024 13:54

Merge branch 'master' into as-upd-rust

f3d3aea

fix try runtime usage in frame-support

a4c861f

Prepare for Rust 1.81

96f2bfc

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Clippy

f676227

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez requested a review from acatangiu as a code owner September 11, 2024 13:46

ggwpez added 2 commits September 18, 2024 17:07

Fix

8aa57b1

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Remove unused test code

f4b1c4a

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

bkchr approved these changes Sep 18, 2024

View reviewed changes

ggwpez and others added 26 commits September 18, 2024 21:24

Update substrate/utils/wasm-builder/src/wasm_project.rs

9edac7a

Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/utils/frame/benchmarking-cli/build.rs

d185393

Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/utils/frame/benchmarking-cli/build.rs

956fc46

Co-authored-by: Bastian Köcher <[email protected]>

Remove unused struct and trait

2248c8a

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

messages-relay: Remove stuff from RelayReference etc

4c4c3a3

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

sc-network: remove more

d1c8045

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Fixup frame-procedural

0d40efb

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

pallet-contracts: remove unused field

a500e2c

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

keep FIXME on buggy test

c7749b9

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fmt

7ba5dc7

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge remote-tracking branch 'origin/as-upd-rust' into as-upd-rust

373beb6

sc-network: remove more

9e14b6c

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

test fix

ed2a8ba

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

pallet-contracts: remove unsued code_len fn

4041c50

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

see if it works without dead_code

dbe084a

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

clippy

d03cf7d

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

clippy

88462de

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

needs deadcode

ab78ab7

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update UI tests

31d2343

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Clippy

9decbcb

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Add manual Debug impl for GrandpaJustification

373dfaf

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Use where clause in Runtime API to make clippy happy

408e60e

Clippy otherwise reports a duplicated trait bound and is unhappy about that. Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fmt toml

0879b8f

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fix rust doc

f5646ee

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fix

8890001

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

doctest

a062000

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

alvicsam commented Sep 11, 2024 •

edited

Loading

alvicsam commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 •

edited

Loading

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 •

edited

Loading

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 •

edited

Loading

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

ggwpez commented Sep 11, 2024

bkchr Sep 18, 2024

bkchr Sep 18, 2024

bkchr Sep 18, 2024

bkchr Sep 18, 2024

bkchr Sep 18, 2024

bkchr Sep 18, 2024

ggwpez Sep 19, 2024

bkchr Sep 18, 2024

ggwpez commented Sep 19, 2024

	impl Encode for EncodeOpaqueValue {
	#[cfg(any(test, feature = "fuzzing"))]
	impl Encode for EncodeOpaqueValue {

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

Are you sure you want to change the base?

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

Conversation

alvicsam commented Sep 11, 2024 • edited Loading

alvicsam commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 • edited Loading

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 • edited Loading

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

command-bot bot commented Sep 11, 2024 • edited Loading

command-bot bot commented Sep 11, 2024

alvicsam commented Sep 11, 2024

ggwpez commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggwpez commented Sep 19, 2024

alvicsam commented Sep 11, 2024 •

edited

Loading

command-bot bot commented Sep 11, 2024 •

edited

Loading

command-bot bot commented Sep 11, 2024 •

edited

Loading

command-bot bot commented Sep 11, 2024 •

edited

Loading