[WIP] RFC-0097 Implementation to Decrease Unbonding Time #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
xlc
reviewed
Oct 8, 2024
|
|
||
| /// Parameters for the unbonding queue mechanism. | ||
| #[pallet::storage] | ||
| pub(crate) type UnbondingQueueParams<T: Config> = StorageValue<_, UnbondingQueue, ValueQuery>; |
There was a problem hiding this comment.
Suggested change
| pub(crate) type UnbondingQueueParams<T: Config> = StorageValue<_, UnbondingQueue, ValueQuery>; | |
| pub(crate) type UnbondingQueueParams<T: Config> = StorageValue<_, UnbondingQueue, OptionQuery>; |
Maybe to not having a default and disable this feature when there is no parameter.
This requires a governance call to set the parameter to enable this feature, which I think should be the preferred way.
There was a problem hiding this comment.
Amended to OptionQuery and added an unbonding params entry to set_staking_configs.
|
Wen are we having this released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement RFC-0097, that introduces a flexible unbonding mechanism to decrease the time stakers have to wait to unbond by as much as 26 eras, resulting in 2 eras / 2 days on Polkadot in the best case scenario.
Commit Log
MinSlashableShare,UnbondPeriodUpperBoundandUnbondPeriodLowerBoundparameters as genesis storage items.UnbondingPeriodUpperBounderas. ThisLowestThirdTotalStakestorage record can be updated when a new planned era is triggered, more specifically in thestore_stakers_infofunction.get_min_lowest_third_stakefunction that gets the lowest third stake entry overUnbondPeriodUpperBounderas.get_quick_unbond_max_unstake(), that will essentially returnMinSlashableShare * min_lowest_third_stake, wheremin_lowest_third_stakeis determined by the above storage addition. Utilising this new storage item is of course less weight heavy than iterating throughErasStakersPaged.unbonding_time_delta- this can use the following formula to determine a concrete unbond block number.back_of_unbonding_queue_block_number.unbonding_block_numberand reflect in unlock chunks.back_of_unbonding_queue_block_numbercalculation.UnbondQueueParamsOptionQuery, None by default, & configurable viaset_staking_configs.unbonding_period_upper_boundas duplicate ofBondingDuration.bonding_durationinterface so pallets likefast-unstakeget the correct unbond duration.