Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solochain to use #[runtime] #5772

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

update solochain to use #[runtime] #5772

wants to merge 8 commits into from

Conversation

Jan-Jan
Copy link
Contributor

@Jan-Jan Jan-Jan commented Sep 19, 2024

Description

  • This is part of issue 5242, specifically getting solochain to use #[frame::runtime]
  • Furthermore, reinforced the convention of Template instead of TemplateModule

Integration

  • Should be integrated into the solochain template and documentation

Review Notes

  • Refactored solochain template from construct_runtime! to #[runtime].
  • AFAIU Template is our new convention, and preferred over TemplateModule.

Out of scope

  • The #[runtime] documentation is still very rudimentary, and should ideally be expanded to explain the macro, both what it does and the input options.
  • Furthermore, suggest update #[runtime] documentation to replace #[crate::runtime] with #[frame_support::runtime]

@Jan-Jan Jan-Jan added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring. labels Sep 19, 2024
@Jan-Jan Jan-Jan requested a review from gupnik September 19, 2024 13:32
@Jan-Jan Jan-Jan changed the title [trivial] update solochain to use #[runtime] Sep 19, 2024
@Jan-Jan Jan-Jan added the R0-silent Changes should not be mentioned in any release notes label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant