cumulus: ParachainBlockData support multiple blocks
#6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck-data-multiple-blocks
…ck-data-multiple-blocks
skunert
approved these changes
Nov 26, 2024
| ) | ||
| }); | ||
| processed_downward_messages += crate::ProcessedDownwardMessages::<PSC>::get(); | ||
| horizontal_messages.try_extend(crate::HrmpOutboundMessages::<PSC>::get().into_iter()).expect( |
There was a problem hiding this comment.
This limit of around 16k messages is now for all blocks in one PoV, not per block anymore right?
…ck-data-multiple-blocks
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to
ParachainBlockDatato support multiple blocks at once. This basically means that cumulus based Parachains could start packaging multiple blocks into onePoV. From the relay chain POV nothing changes and thesePoVs appear like any otherPoV. Internally thisPoVthen executes the blocks sequentially. However, all these blocks together can use the same amount of resources like a singlePoV. This pull request is basically a preparation to support running parachains with a faster block time than the relay chain.This breaks the encoding of
ParachainBlockData. It requires that the collators upgrade first before the runtime requiring the newParachainBlockDatais enacted. The collators will decide based on the api version ofCollectCollationInfo, whichParachainBlockDataformat they will send to the relay chain so that the validation code can interpret it correctly.