test: [DO NOT MERGE] Run ParseUI Swift Demo without Dynamic Targets #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
dplewis
changed the title
|
@mtrezza Looks like Bolts Carthage is broken. I can't run this test. |
|
Then should we remove the ParseUI? |
Yes please! Users should be making their own UI |
|
I agree, this to me seem like it used to be a convenience feature back in the days, but today - especially with SwiftUI - building a layout has become a lot easier. I believe we can remove that. |
|
@mtrezza Can you open an issue? |
|
See #1760 |
|
Closing via #1763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
The only way to remove Bolts from Carthage is to remove all Dynamic Targets. ParseUI Swift Demo is the only target using it. I'm wondering why its not included in the CI build. If this test fails then we will have to remove the ParseUI swift support from the Repo unless we want to keep Bolts Carthage.
Looks like Bolts Carthage has already started failing in other Jobs
https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/6441796016/job/17491943259?pr=1756
https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/6440880523/job/17490133303