Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Automatic loading of PFObject subclasses not working on Xcode 16 #1808

Closed

Conversation

mapierce
Copy link

@mapierce mapierce commented Sep 17, 2024

New Pull Request Checklist

Issue Description

Closes: #1792

Xcode 16 changes the default setting for Enable Debug Dylib Support to YES which adds a suffix of .debug.dylib to the target at runtime meaning the standard call of objc_copyClassNamesForImage with the image name will not find anything while the scheme is running in Debug mode.

Approach

Adding the suffix based on the scheme build configuration fixes the issue to find the target at runtime and makes objc_copyClassNamesForImage work as expected.

Copy link

parse-github-assistant bot commented Sep 17, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mapierce mapierce changed the title Fixes change to ENABLE_DEBUG_DYLIB default fix: Change to ENABLE_DEBUG_DYLIB default Sep 17, 2024
@mman
Copy link
Contributor

mman commented Sep 23, 2024

@mapierce Your PR adds a .debug.dylib filename suffix to the search path, which I understand will lookup the dynamic library with debug symbols when running from Xcode via DEBUG build scheme... that is correct...

But what happens at runtime? Does the issue #1792 not happen at all when the app is archived in release mode?

@mapierce
Copy link
Author

@mman Correct it doesn't happen in release mode. ENABLE_DEBUG_DYLIB being enabled only alters debug builds.

@mtrezza mtrezza changed the title fix: Change to ENABLE_DEBUG_DYLIB default fix: Automatic loading of PFObject subclasses not working on Xcode 16 / iOS 18 Sep 24, 2024
@mtrezza mtrezza changed the title fix: Automatic loading of PFObject subclasses not working on Xcode 16 / iOS 18 fix: Automatic loading of PFObject subclasses not working on Xcode 16 Sep 24, 2024
@mtrezza
Copy link
Member

mtrezza commented Sep 24, 2024

Fixing timeout in #1810 before merging this PR

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for merge?

@mapierce
Copy link
Author

Is this ready for merge?

Hey @mtrezza seems I'm still getting a timeout on two jobs there. I have no ability to re-run them if you wouldn't mind

@mtrezza
Copy link
Member

mtrezza commented Sep 25, 2024

This is strange, because the job passed for #1810 and I haven't found any other timeouts in actions. The timeout seems to be related to this PR, in which case we cannot merge it, because it increases the CI time >=5x. Any idea what may cause this?

@mtrezza
Copy link
Member

mtrezza commented Sep 25, 2024

@mapierce another PR has been opened with #1811, any takeaways?

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2024

@mapierce How should we proceed with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic loading of PFObject subclasses does not work on Xcode 16 / iOS 18
4 participants