Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add a configurable info/error logger #63

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Proposal: Add a configurable info/error logger #63

merged 2 commits into from
Apr 6, 2021

Commits on Apr 6, 2021

  1. Proposal: Add a configurable info/error logger 

    For the sake of backwards compatibility, continue requiring DEBUG=apn to
log either of these.

For the sake of convenience, allow applications to manually override
these loggers on a per-Client instance basis.
A more fully-featured logger such as error/warn/info/debug might be
useful but overkill if the error conditions are rare in practice.

Related to parse-community#59
High volume uses of node-apn may benefit from logging errors but ignore
non-errors.

Related to parse-community#30
- setLogger can be used by applications to set their own prefix
    @TysonAndre
    TysonAndre committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    fe7a446 View commit details
    Browse the repository at this point in the history

  2. Check if errorLogger is enabled

    @TysonAndre
    TysonAndre committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    495263f View commit details
    Browse the repository at this point in the history