Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade semantic-release from 17.4.6 to 21.0.1 #8643

Closed
wants to merge 1 commit into from

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 19, 2023

Pull Request

Issue

semantic-release is currently out-of-date with the newest version being 21.0.1

Closes: n/a

Approach

Update semantic-release and all of its peer dependencies at the same time as the current versions of the peer dependencies are not compatible with the latest version.

Tasks

  • Ensure tests pass

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 19, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (45301a6) 94.41% compared to head (a619811) 94.42%.

❗ Current head a619811 differs from pull request most recent head 01808b8. Consider uploading reports for the commit 01808b8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8643   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files         184      184           
  Lines       14613    14613           
=======================================
+ Hits        13797    13798    +1     
+ Misses        816      815    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 19, 2023

CI Node Engine Check not passing related to #8151

@mtrezza
Copy link
Member

mtrezza commented Jun 19, 2023

This is a major version upgrade, did you read through the changelog to see what the breaking changes are and whether we need to adapt any release config files? You'd need to do a successful local dry-run of the release framework on the same Node version as the release workflow to confirm its still working before this PR can be merged. That's why these dependencies are not always on the latest versions. It doesn't hurt when they aren't, more important is that the release workflow works.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 19, 2023

No, I'm not familiar with semantic-release nor do I use it, so I didn't go through the changelog or do a dry-run. I figured the CI already does the necessary testing to support an update since dependabot updates for semantic-release have been accepted in the past.

The reason I opened this PR is to ensure there isn't a mistake made by dependabot updating semantic-release without updating the respective peer dependencies which can cause issues down the line. I mention this issue here: parse-community/parse-server-fs-adapter#45

If the repo is not ready to accept this PR, this can be closed.

@cbaker6 cbaker6 marked this pull request as draft June 19, 2023 14:13
@mtrezza
Copy link
Member

mtrezza commented Jun 19, 2023

Not sure what you mean by "not ready". Your PR is modifying a CD workflow, not a product feature. Part of such a change is ensuring that the new workflow works.

If you need assistance for how to run the dry-run, I'm here to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants