-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade semantic-release from 17.4.6 to 21.0.1 #8643
Conversation
Thanks for opening this pull request!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## alpha #8643 +/- ##
=======================================
Coverage 94.41% 94.42%
=======================================
Files 184 184
Lines 14613 14613
=======================================
+ Hits 13797 13798 +1
+ Misses 816 815 -1 ☔ View full report in Codecov by Sentry. |
CI Node Engine Check not passing related to #8151 |
This is a major version upgrade, did you read through the changelog to see what the breaking changes are and whether we need to adapt any release config files? You'd need to do a successful local dry-run of the release framework on the same Node version as the release workflow to confirm its still working before this PR can be merged. That's why these dependencies are not always on the latest versions. It doesn't hurt when they aren't, more important is that the release workflow works. |
No, I'm not familiar with semantic-release nor do I use it, so I didn't go through the changelog or do a dry-run. I figured the CI already does the necessary testing to support an update since dependabot updates for semantic-release have been accepted in the past. The reason I opened this PR is to ensure there isn't a mistake made by dependabot updating semantic-release without updating the respective peer dependencies which can cause issues down the line. I mention this issue here: parse-community/parse-server-fs-adapter#45 If the repo is not ready to accept this PR, this can be closed. |
Not sure what you mean by "not ready". Your PR is modifying a CD workflow, not a product feature. Part of such a change is ensuring that the new workflow works. If you need assistance for how to run the dry-run, I'm here to help. |
Pull Request
Issue
semantic-release
is currently out-of-date with the newest version being21.0.1
Closes: n/a
Approach
Update
semantic-release
and all of its peer dependencies at the same time as the current versions of the peer dependencies are not compatible with the latest version.Tasks