Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add option to convert Parse.Object to instance in Cloud Function payload #8646

Merged
merged 11 commits into from
Jun 23, 2023
Merged

refactor: Add option to convert Parse.Object to instance in Cloud Function payload #8646

merged 11 commits into from
Jun 23, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 19, 2023

Pull Request

Issue

#8490 was actually a breaking change because it changes the payload in Cloud Functions in a way that a Parse Pointer JSON is converted to a Parse.Pointer instance in the payload, instead of being just a POJO as it used to be previously.

Closes: #8634

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -9.37 ⚠️

Comparison is base (1850be4) 94.45% compared to head (c1fa585) 85.08%.

❗ Current head c1fa585 differs from pull request most recent head 101ff16. Consider uploading reports for the commit 101ff16 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8646      +/-   ##
==========================================
- Coverage   94.45%   85.08%   -9.37%     
==========================================
  Files         184      184              
  Lines       14635    14635              
==========================================
- Hits        13823    12452    -1371     
- Misses        812     2183    +1371
Impacted Files Coverage Δ
src/Deprecator/Deprecations.js 100.00% <ø> (ø)
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/Routers/FunctionsRouter.js 94.36% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza
mtrezza reviewed Jun 19, 2023
View reviewed changes
spec/CloudCode.spec.js Outdated Show resolved Hide resolved
mtrezza
mtrezza requested changes Jun 19, 2023
View reviewed changes
src/Options/index.js Outdated Show resolved Hide resolved
mtrezza
mtrezza requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temp option, could you also already deprecate it? Should be removed in Parse Server 8 (2025).

@mtrezza mtrezza mentioned this pull request Jun 21, 2023
Merged
2 tasks
@mtrezza
Copy link
Member

mtrezza commented Jun 22, 2023

I think just the deprecation is missing, then we can merge this.

@dblythy dblythy requested a review from mtrezza June 23, 2023 01:45
@dblythy dblythy changed the title refactor: Add option to convert Parse.Pointer in Cloud Function payload refactor: Add option to convert Parse.Object in Cloud Function payload Jun 23, 2023
mtrezza
mtrezza requested changes Jun 23, 2023
View reviewed changes
DEPRECATIONS.md Outdated Show resolved Hide resolved
src/Options/index.js Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title refactor: Add option to convert Parse.Object in Cloud Function payload refactor: Add option to convert Parse.Object to instance in Cloud Function payload Jun 23, 2023
@mtrezza mtrezza merged commit 068fb9e into parse-community:alpha Jun 23, 2023
34 of 47 checks passed
@mtrezza
Copy link
Member

mtrezza commented Jun 23, 2023 •
edited
Loading

As always, right after merging, I noticed that the deprecation date is incorrect. It should be Parse Server 8 (2025) according to our policy to give developers >= 1 year time for breaking changes. I'll correct that, #8657.

@mtrezza mtrezza mentioned this pull request Jun 23, 2023
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 23, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza requested changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to convert Parse.Pointer in Cloud Function payload
3 participants
@dblythy @mtrezza @parseplatformorg