Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove duplicate user index creation #8662

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 25, 2023

Pull Request

Issue

Duplicate code added in #7214. @dplewis I’m guessing this was accident?

Closes: n/a

Approach

Remove duplicate code.

Tasks

  • Ensure tests pass

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 25, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (31805c9) 94.37% compared to head (7e2b7bc) 94.37%.

❗ Current head 7e2b7bc differs from pull request most recent head 0d07cf6. Consider uploading reports for the commit 0d07cf6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8662      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files         185      185              
  Lines       14761    14753       -8     
==========================================
- Hits        13931    13923       -8     
  Misses        830      830              
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 94.19% <ø> (+0.20%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6 cbaker6 closed this Jun 25, 2023
@cbaker6 cbaker6 reopened this Jun 25, 2023
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 25, 2023

@mtrezza @dblythy this is ready for review

Copy link
Member

@dblythy dblythy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pickup!

@mtrezza mtrezza requested review from a team and removed request for a team June 26, 2023 11:53
@mtrezza mtrezza changed the title refactor: Remove duplicate user index refactor: Remove duplicate user index creation Jun 29, 2023
@mtrezza mtrezza merged commit 3f03bd3 into parse-community:alpha Jun 29, 2023
8 of 24 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 4, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants