Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve Postgres init to reuse connection #8663

Open
wants to merge 17 commits into
base: alpha
Choose a base branch
from

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 25, 2023

Pull Request

Issue

Connections are not reused during Postgres init. This is very old leftover TODO from #4375 (comment)

Closes: n/a

Approach

Reuse connection in transaction.

Tasks

  • Ensure all tests pass

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 25, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@cbaker6 cbaker6 marked this pull request as draft June 25, 2023 18:49
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.78%. Comparing base (c277739) to head (1455ef5).
Report is 1 commits behind head on alpha.

Files Patch % Lines
...dapters/Storage/Postgres/PostgresStorageAdapter.js 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8663      +/-   ##
==========================================
- Coverage   94.14%   93.78%   -0.37%     
==========================================
  Files         186      186              
  Lines       14687    14683       -4     
==========================================
- Hits        13827    13770      -57     
- Misses        860      913      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 marked this pull request as ready for review June 26, 2023 06:41
@cbaker6 cbaker6 marked this pull request as draft June 26, 2023 15:12
@mtrezza mtrezza marked this pull request as ready for review March 23, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants