fix: Server does not start via CLI when `auth` option is set #8669

dblythy · 2023-06-27T04:37:07Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #8665

Approach

See Related: #8666.

parse-github-assistant · 2023-06-27T04:37:10Z

Thanks for opening this pull request!

dblythy · 2023-06-27T04:37:43Z

@FransGH please try this one out:

npm install dblythy/parse-server#fix-auth-parser-lts

codecov · 2023-06-27T05:57:44Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a036071) 94.12% compared to head (d30d814) 94.12%.

❗ Current head d30d814 differs from pull request most recent head 78417ea. Consider uploading reports for the commit 78417ea to get more accurate results

Additional details and impacted files

@@              Coverage Diff               @@
##           release-5.x.x    #8669   +/-   ##
==============================================
  Coverage          94.12%   94.12%           
==============================================
  Files                183      183           
  Lines              13798    13803    +5     
==============================================
+ Hits               12987    12992    +5     
  Misses               811      811

Impacted Files	Coverage Δ
src/Options/Definitions.js	`100.00% <ø> (ø)`
src/Options/index.js	`100.00% <ø> (ø)`
src/Controllers/DatabaseController.js	`93.96% <100.00%> (+0.05%)`	⬆️
src/RestWrite.js	`94.61% <100.00%> (-0.04%)`	⬇️
src/Routers/FilesRouter.js	`93.25% <100.00%> (-0.05%)`	⬇️
src/Utils.js	`98.13% <100.00%> (+0.09%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

FransGH · 2023-06-27T10:59:32Z

Just deployed dblythy/parse-server#fix-auth-parser-lts to staging and all seems to work fine!

Thanks Daniel for addressing this so quickly :)

dblythy · 2023-06-27T12:16:09Z

Thanks for reviewing @FransGH!

mtrezza · 2023-06-27T13:16:28Z

@dblythy could you please add the fix to the PR description, and also a link to the alpha branch PR (if there is one)? Thanks!

dblythy · 2023-06-27T13:32:50Z

Sorry, the alpha PR is #8666

FransGH · 2023-06-27T15:06:24Z

@mtrezza not the most important but the problem is that the server fails to start via CLI when auth is configured (as opposed to just auth-adapters not loading)

mtrezza · 2023-06-27T18:07:53Z

Thanks for pointing this out, the PR title will be the changelog entry, so it's important we get this right. The server fails to start via CLI when auth is configured as a CLI parameter? If so, how about this title:

fix: Server does not start via CLI with --auth parameter set

FransGH · 2023-06-27T18:21:24Z

I didn't try via --auth, only via a config.json. Assume however that it's independent of where the CLI gets the config from. Config file, cmd parameters and env-variables should have the same checks.

mtrezza · 2023-06-27T18:24:58Z

So you were using a config file and were passing that via the CLI?

FransGH · 2023-06-27T18:30:00Z

Yes, but only on staging and production. During dev a server instance is started via API where apparently the config is not so strictly checked.

mtrezza · 2023-06-27T18:53:25Z

Got it, different checks for CLI vs. API doesn't sound good. Do you want to open an issue to centralize the checks for config options regardless of how they are set? Sounds like a general issue.

How about this:

fix: Server does not start via CLI when passing a config file with auth parameter set

FransGH · 2023-06-27T20:29:06Z

Thought about opening an issue for that but don't have time at the moment to contribute in fixing it. So not sure if it makes sense creating one?

FransGH · 2023-06-27T20:33:37Z

fix: Server does not start via CLI when passing a config file with auth parameter set

"Fix: Server does not start via CLI when the auth option is set."

mtrezza · 2023-06-28T07:01:10Z

Thought about opening an issue for that but don't have time at the moment to contribute in fixing it. So not sure if it makes sense creating one?

Sure, you don't need to contribute in fixing an issue - if you only want to report it that also helps.

FransGH · 2023-06-28T14:06:34Z

@mtrezza just for my understanding, what would be the approximate timeline for seeing this in a 5.x release update?
(I can work around this but would rather upgrade with an official release)

spec/CLI.spec.js

mtrezza

Looks good!

## [5.5.3](5.5.2...5.5.3) (2023-06-29) ### Bug Fixes * Server does not start via CLI when `auth` option is set ([#8669](#8669)) ([601da1e](601da1e))

parseplatformorg · 2023-06-29T20:06:45Z

🎉 This change has been released in version 5.5.3

fix: (LTS) Auth does not load when starting Parse Server via CLI

ad9378b

dblythy changed the base branch from alpha to release-5.x.x June 27, 2023 04:37

dblythy changed the title ~~Fix auth parser lts~~ fix: (LTS) Auth does not load when starting Parse Server via CLI Jun 27, 2023

dblythy closed this Jun 27, 2023

dblythy reopened this Jun 27, 2023

FransGH approved these changes Jun 27, 2023

View reviewed changes

dblythy requested a review from a team June 27, 2023 12:16

mtrezza changed the title ~~fix: (LTS) Auth does not load when starting Parse Server via CLI~~ fix: Auth does not load when starting Parse Server via CLI Jun 27, 2023

mtrezza changed the title ~~fix: Auth does not load when starting Parse Server via CLI~~ fix: Server does not start via CLI when the auth option is set Jun 28, 2023

mtrezza changed the title ~~fix: Server does not start via CLI when the auth option is set~~ fix: Server does not start via CLI when auth option is set Jun 28, 2023

mtrezza requested changes Jun 28, 2023

View reviewed changes

spec/CLI.spec.js Outdated Show resolved Hide resolved

dblythy added 2 commits June 29, 2023 13:18

Merge branch 'release-5.x.x' into fix-auth-parser-lts

36d404b

Update CLI.spec.js

78417ea

dblythy requested a review from a team June 29, 2023 04:57

FransGH approved these changes Jun 29, 2023

View reviewed changes

mtrezza merged commit 601da1e into parse-community:release-5.x.x Jun 29, 2023

mtrezza reviewed Jun 29, 2023

View reviewed changes

parseplatformorg pushed a commit that referenced this pull request Jun 29, 2023

chore(release): 5.5.3 [skip ci]

9c0abe0

## [5.5.3](5.5.2...5.5.3) (2023-06-29) ### Bug Fixes * Server does not start via CLI when `auth` option is set ([#8669](#8669)) ([601da1e](601da1e))

parseplatformorg added the state:released-5.x.x Released as LTS version label Jun 29, 2023

dblythy deleted the fix-auth-parser-lts branch June 30, 2023 03:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Server does not start via CLI when `auth` option is set #8669

fix: Server does not start via CLI when `auth` option is set #8669

dblythy commented Jun 27, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jun 27, 2023 •

edited

Loading

dblythy commented Jun 27, 2023

codecov bot commented Jun 27, 2023 •

edited

Loading

FransGH commented Jun 27, 2023

dblythy commented Jun 27, 2023

mtrezza commented Jun 27, 2023 •

edited

Loading

dblythy commented Jun 27, 2023

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023 •

edited

Loading

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023 •

edited

Loading

FransGH commented Jun 27, 2023

FransGH commented Jun 27, 2023 •

edited

Loading

mtrezza commented Jun 28, 2023

FransGH commented Jun 28, 2023

mtrezza left a comment

parseplatformorg commented Jun 29, 2023

fix: Server does not start via CLI when auth option is set #8669

fix: Server does not start via CLI when auth option is set #8669

Conversation

dblythy commented Jun 27, 2023 • edited by mtrezza Loading

Pull Request

Issue

Approach

parse-github-assistant bot commented Jun 27, 2023 • edited Loading

Thanks for opening this pull request!

dblythy commented Jun 27, 2023

codecov bot commented Jun 27, 2023 • edited Loading

Codecov Report

FransGH commented Jun 27, 2023

dblythy commented Jun 27, 2023

mtrezza commented Jun 27, 2023 • edited Loading

dblythy commented Jun 27, 2023

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023 • edited Loading

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023

FransGH commented Jun 27, 2023

mtrezza commented Jun 27, 2023 • edited Loading

FransGH commented Jun 27, 2023

FransGH commented Jun 27, 2023 • edited Loading

mtrezza commented Jun 28, 2023

FransGH commented Jun 28, 2023

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented Jun 29, 2023

fix: Server does not start via CLI when `auth` option is set #8669

fix: Server does not start via CLI when `auth` option is set #8669

dblythy commented Jun 27, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jun 27, 2023 •

edited

Loading

codecov bot commented Jun 27, 2023 •

edited

Loading

mtrezza commented Jun 27, 2023 •

edited

Loading

mtrezza commented Jun 27, 2023 •

edited

Loading

mtrezza commented Jun 27, 2023 •

edited

Loading

FransGH commented Jun 27, 2023 •

edited

Loading