Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for incrementing number atomically #8789

Open
wants to merge 14 commits into
base: alpha
Choose a base branch
from

Conversation

theolundqvist
Copy link

@theolundqvist theolundqvist commented Oct 24, 2023

Pull Request

Issue

Closes: #8772 (cloud increment atomicity not working)

Approach

There does not seem to be a test that tests proper atomicity. This should be granted by mongo but here we are anyways.

Tasks

  • Add tests

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@theolundqvist theolundqvist changed the title add test for #8772 test: add test for #8772 Oct 24, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: add test for #8772 test: Add test for #8772 Oct 24, 2023
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
spec/schemas.spec.js Outdated Show resolved Hide resolved
spec/schemas.spec.js Outdated Show resolved Hide resolved
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <[email protected]>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (9552a4c) to head (6f52f4d).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8789   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         186      186           
  Lines       14806    14806           
=======================================
+ Hits        13839    13840    +1     
+ Misses        967      966    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title test: Add test for #8772 test: Add test for incrementing atomically Mar 25, 2024
@mtrezza mtrezza changed the title test: Add test for incrementing atomically test: Add test for incrementing number atomically Mar 25, 2024
@mtrezza
Copy link
Member

mtrezza commented Mar 25, 2024

@theolundqvist the tests have passed; does that mean that there is no issue with atomically incrementing?

spec/ParseObject.spec.js Outdated Show resolved Hide resolved
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <[email protected]>
@theolundqvist
Copy link
Author

@mtrezza I'm not so sure about that, I believe they passed when I created them. But I still had trouble with it.

I am not invested in the parse platform anymore so do not have time to run further experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment does not appear to be atomic
3 participants