Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak from policy registration (#1660) #13

Merged

Conversation

rodion-lim-partior
Copy link

There is a memory leak when registering validators to a proposal policy registry. See Consensys#1687.

This hotfix is created to address the memory leak. Evidence documented in https://partior.atlassian.net/browse/SET-389

Copy link

@john-sobrepena-partior john-sobrepena-partior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this changes with Rodion. Code changes and tests results looks good. Approving this change so that further regression testing can be performed.

@anthony-yeong-partior anthony-yeong-partior merged commit ea07829 into base/v23.4.0 Jan 8, 2024
22 of 23 checks passed
@anthony-yeong-partior anthony-yeong-partior deleted the hotfix/SET-389-fix-validator-memory-leak branch January 8, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants