Add import statement (#57) #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlurton
commented
May 14, 2021
Comment on lines
15
to
17
|
|
||
| package org.partiql.pig.domain.parser | ||
|
|
There was a problem hiding this comment.
For this file, I strongly recommend clicking the gear icon near the top and checking the box "hide whitespace changes" as most of the modified lines are just indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #57.
I need to account for the actual use-case here: another project will have already generated code for the domain being imported, so there should be a way to avoid re-generating the same code from the imported domains. This is perhaps more complex than it would at first appear since the generated code of the imported domain may be in Kotlin package, and the PIG DSL itself has no notion of these packages. I need to think of a simple solution.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.