Merge pull request #1647 from johnedquinn/v1-fn-consolidation

Rewrites PLUS and BITWISE_AND implementations using new modeling
partiql · Nov 19, 2024 · 6a4b3e2 · 6a4b3e2
2 parents 10f93bd + 4c9bc85
commit 6a4b3e2
Show file tree

Hide file tree

Showing 42 changed files with 1,009 additions and 605 deletions.
diff --git a/partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rex/ExprCallDynamic.kt b/partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rex/ExprCallDynamic.kt
@@ -103,7 +103,10 @@ internal class ExprCallDynamic(
                 exactMatches = currentExactMatches
             }
         }
-        return if (currentMatch == null) null else Candidate(functions[currentMatch!!].getInstance(args.toTypedArray()))
+        return if (currentMatch == null) null else {
+            val instance = functions[currentMatch!!].getInstance(args.toTypedArray()) ?: return null
+            Candidate(instance)
+        }
     }
 
     /**

diff --git a/partiql-eval/src/test/kotlin/org/partiql/eval/PTestCase.kt b/partiql-eval/src/test/kotlin/org/partiql/eval/PTestCase.kt
@@ -0,0 +1,8 @@
+package org.partiql.eval
+
+interface PTestCase : Runnable {
+    /**
+     * Executes the test case
+     */
+    override fun run()
+}