Rebase EXCLUDE on ORDER BY typing

partiql · Oct 9, 2023 · c249729 · c249729
1 parent f60802c
commit c249729
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...-lang/src/test/kotlin/org/partiql/lang/planner/transforms/PartiQLSchemaInferencerTests.kt b/...-lang/src/test/kotlin/org/partiql/lang/planner/transforms/PartiQLSchemaInferencerTests.kt
@@ -83,10 +83,10 @@ class PartiQLSchemaInferencerTests {
     @Execution(ExecutionMode.CONCURRENT)
     fun testJoins(tc: TestCase) = runTest(tc)
 
-    // @ParameterizedTest
-    // @MethodSource("excludeCases")
-    // @Execution(ExecutionMode.CONCURRENT)
-    // fun testExclude(tc: TestCase) = runTest(tc)
+    @ParameterizedTest
+    @MethodSource("excludeCases")
+    @Execution(ExecutionMode.CONCURRENT)
+    fun testExclude(tc: TestCase) = runTest(tc)
 
     @ParameterizedTest
     @MethodSource("orderByCases")

diff --git a/partiql-planner/src/main/kotlin/org/partiql/planner/typer/PlanTyper.kt b/partiql-planner/src/main/kotlin/org/partiql/planner/typer/PlanTyper.kt
@@ -327,7 +327,7 @@ internal class PlanTyper(
             val init = input.type.schema.map { it.copy() }
             val schema = node.items.fold((init)) { bindings, item -> excludeBindings(bindings, item) }
 
-            //
+            // rewrite
             val type = ctx!!.copy(schema)
             return rel(type, node)
         }