Use SPECIFIC as implementation class name for builtins

partiql · Jan 4, 2024 · dd43328 · dd43328
1 parent f129381
commit dd43328
Show file tree

Hide file tree

Showing 90 changed files with 2,471 additions and 1,290 deletions.
diff --git a/partiql-planner/build.gradle.kts b/partiql-planner/build.gradle.kts
@@ -35,7 +35,6 @@ dependencies {
     testImplementation(project(":partiql-parser"))
     testImplementation(project(":plugins:partiql-local"))
     testImplementation(project(":plugins:partiql-memory"))
-    testImplementation(Deps.kasechange)
     // Test Fixtures
     testFixturesImplementation(project(":partiql-spi"))
 }

diff --git a/partiql-planner/src/test/kotlin/org/partiql/planner/internal/typer/FunctionResolverTest.kt b/partiql-planner/src/test/kotlin/org/partiql/planner/internal/typer/FunctionResolverTest.kt
@@ -2,7 +2,6 @@ package org.partiql.planner.internal.typer
 
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.fail
-import org.partiql.planner.internal.Header
 import org.partiql.spi.connector.ConnectorFunctions
 import org.partiql.types.function.FunctionParameter
 import org.partiql.types.function.FunctionSignature
@@ -17,24 +16,6 @@ import org.partiql.value.PartiQLValueType
 @OptIn(PartiQLValueExperimental::class)
 class FunctionResolverTest {
 
-    @Test
-    fun sanity() {
-        // 1 + 1.0 -> 2.0
-        val fn = Header.binary(
-            name = "plus",
-            returns = PartiQLValueType.FLOAT64,
-            lhs = PartiQLValueType.FLOAT64,
-            rhs = PartiQLValueType.FLOAT64,
-        )
-        val args = listOf(
-            FunctionParameter("arg-0", PartiQLValueType.INT32),
-            FunctionParameter("arg-1", PartiQLValueType.FLOAT64),
-        )
-        val expectedImplicitCasts = listOf(true, false)
-        val case = Case.Success(fn, args, expectedImplicitCasts)
-        case.assert()
-    }
-
     @Test
     fun split() {
         val args = listOf(

diff --git a/plugins/partiql-plugin/build.gradle.kts b/plugins/partiql-plugin/build.gradle.kts
@@ -23,4 +23,8 @@ plugins {
 dependencies {
     implementation(project(":partiql-spi"))
     implementation(project(":partiql-types"))
+
+    // Header Generation
+    testImplementation(project(":partiql-ast"))
+    testImplementation(Deps.kasechange)
 }