Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NULL typing to JOIN operators #1239

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented Oct 4, 2023

Relevant Issues

#1238

Description

When performing a LEFT (or RIGHT join), we must type the right-hand-side (or left-hand-side) as nullable because these joins pad the resultant tuple with NULLs if the condition fails to match.

This logic will type a non-struct value as nullable, but will type the fields of a struct value as nullable. This allows for SQL compatibility of the JOIN operators. Details in Issue #1238

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    No

  • Any backward-incompatible changes? [YES/NO]
    This changes the behavior of PlanTyperV0

  • Any new external dependencies? [YES/NO]
    No

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchowell rchowell requested a review from johnedquinn October 4, 2023 22:01
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Conformance comparison report

Base (d37da34) 8432f04 +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (d37da34) but now fail: 0

Number failing in Base (d37da34) but now pass: 0

@rchowell rchowell merged commit 0495946 into partiql-planner Oct 6, 2023
@rchowell rchowell deleted the planner-join-nulls branch January 18, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant