Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds session binders #1252

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Adds session binders #1252

merged 1 commit into from
Oct 25, 2023

Conversation

johnedquinn
Copy link
Member

Relevant Issues

  • None

Description

  • Small PR to update the default binders for CURRENT_USER and CURRENT_DATE.
  • Now, SELECT CURRENT_USER previously normalized to SELECT CURRENT_USER AS "_1", but now, it normalized to: SELECT CURRENT_USER AS "CURRENT_USER"

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • No, not to main.
  • Any backward-incompatible changes? [YES/NO]

    • No
  • Any new external dependencies? [YES/NO]

    • No
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnedquinn johnedquinn marked this pull request as ready for review October 25, 2023 18:44
@github-actions
Copy link

Conformance comparison report

Base (9e151c2) 91cad2d +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (9e151c2) but now fail: 0

Number failing in Base (9e151c2) but now pass: 0

@johnedquinn johnedquinn merged commit 6f26c42 into partiql-planner Oct 25, 2023
8 of 10 checks passed
@johnedquinn johnedquinn deleted the update-session-binders branch March 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants