Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pathing of expressions #1255

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fixes pathing of expressions #1255

merged 1 commit into from
Nov 1, 2023

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Nov 1, 2023

Relevant Issues

  • None

Description

  • Fixes pathing of expressions by visiting root.
  • Adds tests for pathing
  • Previously, queries would fail because we would forget to type the root of paths (unless the rex was a variable). The following used to fail:
    • [0, 1, 2, 3][0]
    • SELECT typical_allergies[0] AS main_allergy FROM dogs
    • and more
  • While this PR doesn't have anything to do with scalar functions, I was previously adding tests for scalar functions and am including them here. See testScalarFunctions in the schema inference tests.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds tests for pathing and scalar functions
@johnedquinn johnedquinn requested a review from RCHowell November 1, 2023 19:42
@johnedquinn johnedquinn marked this pull request as ready for review November 1, 2023 19:42
Copy link

github-actions bot commented Nov 1, 2023

Conformance comparison report

Base (234ff97) 39754d4 +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (234ff97) but now fail: 0

Number failing in Base (234ff97) but now pass: 0

@RCHowell RCHowell merged commit fb25dfa into partiql-planner Nov 1, 2023
8 of 10 checks passed
@johnedquinn johnedquinn deleted the fix-pathing branch March 7, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants