Support ANY type in Header functions And Planning of Control Flow Functions. #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yliuuuu
commented
Nov 1, 2023
partiql-planner/src/main/kotlin/org/partiql/planner/PartiQLHeader.kt
Outdated
Show resolved
Hide resolved
yliuuuu
commented
Nov 1, 2023
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (234ff97) but now fail: 0 Number failing in Base (234ff97) but now pass: 0 |
RCHowell
requested changes
Nov 1, 2023
Comment on lines
136
to
178
| private fun lt(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("lt", BOOL, t, t) | ||
| } | ||
| } + listOf(binary("lt", ANY, ANY, ANY)) | ||
|
|
||
| private fun lte(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("lte", BOOL, t, t) | ||
| } | ||
| } + listOf(binary("lte", ANY, ANY, ANY)) | ||
|
|
||
| private fun gt(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("gt", BOOL, t, t) | ||
| } | ||
| } + listOf(binary("gt", ANY, ANY, ANY)) | ||
|
|
||
| private fun gte(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("gte", BOOL, t, t) | ||
| } | ||
| } + listOf(binary("gte", ANY, ANY, ANY)) | ||
|
|
||
| private fun plus(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("plus", t, t, t) | ||
| } | ||
| } + listOf(binary("plus", ANY, ANY, ANY)) | ||
|
|
||
| private fun minus(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("minus", t, t, t) | ||
| } | ||
| } + listOf(binary("minus", ANY, ANY, ANY)) | ||
|
|
||
| private fun times(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("times", t, t, t) | ||
| } | ||
| } + listOf(binary("times", ANY, ANY, ANY)) | ||
|
|
||
| private fun div(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("divide", t, t, t) | ||
| } | ||
| } + listOf(binary("divide", ANY, ANY, ANY)) | ||
|
|
||
| private fun mod(): List<FunctionSignature.Scalar> = types.numeric.map { t -> | ||
| binary("modulo", t, t, t) | ||
| } | ||
| } + listOf(binary("modulo", ANY, ANY, ANY)) | ||
|
|
||
| private fun concat(): List<FunctionSignature.Scalar> = types.text.map { t -> | ||
| binary("concat", t, t, t) | ||
| } | ||
| } + listOf(binary("concat", ANY, ANY, ANY)) | ||
|
|
||
| private fun bitwiseAnd(): List<FunctionSignature.Scalar> = types.integer.map { t -> | ||
| binary("bitwise_and", t, t, t) | ||
| } | ||
| } + listOf(binary("bitwise_and", ANY, ANY, ANY)) |
There was a problem hiding this comment.
These are slightly different functions. The return type is still BOOL, but the functions are MISSABLE because we could have a mis-typing case.
partiql-planner/src/main/kotlin/org/partiql/planner/PartiQLHeader.kt
Outdated
Show resolved
Hide resolved
yliuuuu
changed the title
RCHowell
approved these changes
Nov 2, 2023
Comment on lines
-329
to
-345
| // TODO | ||
| private fun coalesce(): List<FunctionSignature.Scalar> = emptyList() | ||
|
|
||
| // NULLIF(x, y) | ||
| private fun nullIf(): List<FunctionSignature.Scalar> = types.nullable.map { t -> | ||
| FunctionSignature.Scalar( | ||
| name = "null_if", | ||
| returns = t, | ||
| parameters = listOf( | ||
| FunctionParameter("value", t), | ||
| FunctionParameter("nullifier", BOOL), // TODO: why is this BOOL? | ||
| ), | ||
| isNullCall = true, | ||
| isNullable = true, | ||
| ) | ||
| } | ||
|
|
| name = "date_diff_${field.name.lowercase()}", | ||
| returns = ANY, | ||
| parameters = listOf( | ||
| FunctionParameter("interval", INT), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
coalesceandnullIfwill be rewrited to a case when expression.Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
Any new external dependencies? [YES/NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.