Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes derived binder numbering #1269

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

RCHowell
Copy link
Member

Description

We lost derived binding value in the SELECT * and didn't have tests on our normalization passes. This simply adds them back via slightly different mechanism. Rather than using the select item index, we increment a shared count.

-- Example
SELECT a, bar(b), baz(c) FROM T

-- before used index (ie _2 and _3)
SELECT VALUE { 'a': a, '_2': bar(b), '_3': baz(c) FROM T

-- bug (always was _1)
SELECT VALUE { 'a': a,  '_1': bar(b), '_1': baz(c) } FROM T

-- bug fixed and counts up
SELECT VALUE { 'a': a, '_1': bar(b), '_2': baz(c) FROM T


Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    No

  • Any backward-incompatible changes? [YES/NO]
    No

  • Any new external dependencies? [YES/NO]
    No

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RCHowell RCHowell requested a review from johnedquinn November 20, 2023 22:44
Copy link

Conformance comparison report

Base (9e1bebe) f12fda0 +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (9e1bebe) but now fail: 0

Number failing in Base (9e1bebe) but now pass: 0

@RCHowell RCHowell merged commit 63f8b72 into partiql-planner Nov 21, 2023
10 checks passed
@RCHowell RCHowell deleted the partiql-planner-aggs branch November 21, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants