Modifies how we model paths in the plan #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (c23ca8c) but now fail: 0 Number failing in Base (c23ca8c) but now pass: 0 |
|
Will review after rebase. Thank you. |
RCHowell
requested changes
Nov 29, 2023
Comment on lines
165
to
170
| org.partiql.ast.Identifier.CaseSensitivity.SENSITIVE -> rexOpPathStepKey( | ||
| rex( | ||
| type = StaticType.STRING, | ||
| op = rexOpLit(stringValue(it.symbol.symbol)) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
We want this to be a rexOpPathSymbol right? For global resolution.
a."x" != a["x"] -- !! only for global variable names, the prior is treated as a qualified identifier
There was a problem hiding this comment.
With your recent PR for internalizing the unresolved IRs, I added the retention of this subtle difference to the internal IR. Then, converting from the internal to the public, I transform it accordingly. See the updated PR description.
johnedquinn
force-pushed
the
modeling-paths
branch
from
007214b to
b9330c9
Compare
RCHowell
approved these changes
Nov 30, 2023
Comment on lines
+131
to
+132
| Identifier.CaseSensitivity.SENSITIVE -> rexOpPathStepKey(rex(StaticType.STRING, rexOpLit(stringValue(node.identifier.symbol)))) | ||
| Identifier.CaseSensitivity.INSENSITIVE -> rexOpPathStepSymbol(node.identifier.symbol) |
There was a problem hiding this comment.
Nice, here's a notable difference between the typing structure and the public API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
a[0], a[1 + 1]a."b", a['b'], a[CAST('a' || 'b' AS STRING)]a.ba.b,a."b", anda['b']when we haven't typed yet-- the internal APIs contain:a[0], a[1 + 1]a['b'], a[CAST('a' || 'b' AS STRING)]a.banda."b". This has a subtle difference to the public API.PartiQLSchemaInferencerTestsfor more information.Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.