Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds literal STRUCT test #1299

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Adds literal STRUCT test #1299

merged 1 commit into from
Dec 20, 2023

Conversation

johnedquinn
Copy link
Member

Relevant Issues

  • None

Description

  • Adds literal STRUCT test just so we don't accidentally break anything in future.

Other Information

  • Updated Unreleased Section in CHANGELOG: NO

  • Any backward-incompatible changes? [YES/NO]

    • No, just adding a test.
  • Any new external dependencies? NO

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Dec 12, 2023

Conformance comparison report

Base (5617ef6) b2b763c +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (5617ef6) but now fail: 0

Number failing in Base (5617ef6) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-eval@dccab37). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             partiql-eval    #1299   +/-   ##
===============================================
  Coverage                ?   49.28%           
  Complexity              ?     1046           
===============================================
  Files                   ?      166           
  Lines                   ?    13392           
  Branches                ?     2500           
===============================================
  Hits                    ?     6600           
  Misses                  ?     6135           
  Partials                ?      657           
Flag Coverage Δ
CLI 11.87% <0.00%> (?)
EXAMPLES 80.28% <0.00%> (?)
LANG 54.72% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchowell
Copy link
Contributor

Holding off on this until removing sequences in values

@rchowell rchowell merged commit 35377df into partiql-eval Dec 20, 2023
10 checks passed
@rchowell rchowell deleted the eval-struct branch December 20, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants