Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds qualifiers to function call expressions #1337

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

RCHowell
Copy link
Member

Description

This PR extends the PartiQL grammar to support qualified identifiers in routine invocation (FunctionCall). The AST already models this so this PR does not introduce an AST changes.

SQL-99 10.4 p.354 — Routine Invocation

<routine invocation> ::= <routine name> <SQL argument list>

<routine name> ::= [ <schema name> <period> ] <qualified identifier>

IMPORTANT

We may need to introduce larger changes to the grammar as this PR does not add qualified names to special forms.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    No

  • Any backward-incompatible changes? [YES/NO]
    No

  • Any new external dependencies? [YES/NO]
    No

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RCHowell RCHowell requested a review from johnedquinn January 12, 2024 22:56
Copy link

Conformance comparison report

Base (dae1ab3) 425001f +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (dae1ab3) but now fail: 0

Number failing in Base (dae1ab3) but now pass: 0

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Nice work.

@RCHowell RCHowell merged commit 1e1a71f into main Jan 16, 2024
10 checks passed
@RCHowell RCHowell deleted the qualified-functions branch January 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants