-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for PERMISSIVE vs STRICT #1353
Conversation
Conformance comparison report-Cross Engine
Number failing in both: 431 Number passing in legacy engine but fail in eval engine: 3843 Number failing in legacy engine but pass in eval engine: 3 Click here to see
Conformance comparison report-Cross Commit-LEGACY
Number failing in both: 434 Number passing in Base (101c19b) but now fail: 0 Number failing in Base (101c19b) but now pass: 0 Conformance comparison report-Cross Commit-EVAL
Number failing in both: 4220 Number passing in Base (101c19b) but now fail: 54 Number failing in Base (101c19b) but now pass: 312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. Have some out of scope comments but you don't have to address those in this PR.
partiql-eval/src/test/kotlin/org/partiql/eval/internal/PartiQLEngineDefaultTest.kt
Show resolved
Hide resolved
private var isIndexable: Boolean = true | ||
|
||
override fun open() { | ||
val r = expr.eval(Record.empty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but does this work for subquery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I have a subquery PR out, and when I rebase, I'll take a look at that.
return rootEvaluated[keyString] ?: missingValue() | ||
return rootEvaluated[keyString] ?: throw TypeCheckException() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuple navigation in tuples with duplicate attributes When the tuple t has multiple attributes a, the tuple
path navigation t.a will return the first instance of a. Note that for tuples whose order is defined by schema, this is well-defined, for unordered tuples, it is implementation defined which attribute is returned in permissive mode or an error in type checking mode, which is described in Section 4.1
It seems like right now we don't have the notion of ordered vs unordered struct during runtime. Maybe just keep a todo note here?
Relevant Issues
Description
RelScanPermissive
for example.LIKE
by copying much of the logic from EvaluatingCompiler. If requested, I can remove these additions and include them in a separate PR.Testing
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.