Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates partiql-planner to latest partiql-spi interfaces #1358

Merged
merged 18 commits into from
Feb 1, 2024

Conversation

RCHowell
Copy link
Member

@RCHowell RCHowell commented Jan 31, 2024

There are still 11 planner tests failing (several just from error assertions)

[PlanTyperTestsPorted](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html). [[7] unary plus on missing type -- this cannot resolve to a dynamic call since no function will ever be invoked. : SELECT VALUE +t.a FROM << { 'NOT_A': 1 } >> AS t](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html#testDynamicCalls(TestCase)[7])
    [PlanTyperTestsPorted](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html). [[36] EXCLUDE using a catalog : Key(group=schema_inferencer, name=exclude-36)](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html#testExclude(TestCase)[36])
    [PlanTyperTestsPorted](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html). [8] Show that we can't use [<string>] to reference a value in a schema. It can only be used on tuples. : SELECT VALUE 1 FROM "pql"."main"['employer'] AS e;
    [PlanTyperTestsPorted](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.PlanTyperTestsPorted.html). [9] Show that we can't use [<string>] to reference a schema in a catalog. It can only be used on tuples. : SELECT VALUE 1 FROM "pql"['main']."employer" AS e;
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-09] t1.y['y'][CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[10][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-10] t1.y."y"[CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[11][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-12] t1[0]['y'][CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[13][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-13] t1[0]."y"[CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[14][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-14] t1['y']."y"[CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[15][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-04] -- tuple navigation with explicit cast as string t1[CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[5][1])
    [SanityTests](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html). [--#[paths-07] t1.y[0][CAST(t2 AS STRING)]; | path_Success_any_0 | [any, any]](file:///Users/howero/Projects/partiql-lang-kotlin/partiql-planner/build/reports/tests/test/classes/org.partiql.planner.internal.typer.path.SanityTests.html#path()[8][1])

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RCHowell RCHowell merged commit d387ff2 into partiql-spi Feb 1, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant