Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build and unit test in PartiQL SPI merge #1361

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Feb 3, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • Resolve Build Issue. Fix unit tests.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • < If NO, why? >
  • Any backward-incompatible changes? [YES/NO]

    • < If YES, why? >
    • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
      errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yliuuuu yliuuuu changed the title ktlint Fix Build and unit test in PartiQL SPI merge Feb 3, 2024
Copy link

github-actions bot commented Feb 3, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.47% 25.23% -67.24%
✅ Passing 5380 1468 -3912
❌ Failing 438 4350 3912
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 1465

Number failing in both: 435

Number passing in legacy engine but fail in eval engine: 3915

Number failing in legacy engine but pass in eval engine: 3
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
The following test(s) are failing in legacy but pass in eval. Before merging, confirm they are intended to pass:

Click here to see
  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: PERMISSIVE

  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: LEGACY

  • missing and true, compileOption: PERMISSIVE

Conformance comparison report-Cross Commit-LEGACY

Base (edabd2b) 55805cd +/-
% Passing 92.47% 92.47% 0.00%
✅ Passing 5380 5380 0
❌ Failing 438 438 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5380

Number failing in both: 438

Number passing in Base (edabd2b) but now fail: 0

Number failing in Base (edabd2b) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (edabd2b) 55805cd +/-
% Passing 25.23% 25.23% 0.00%
✅ Passing 1468 1468 0
❌ Failing 4350 4350 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 1468

Number failing in both: 4350

Number passing in Base (edabd2b) but now fail: 0

Number failing in Base (edabd2b) but now pass: 0

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-spi-merge@edabd2b). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             partiql-spi-merge    #1361   +/-   ##
====================================================
  Coverage                     ?   50.32%           
  Complexity                   ?     1045           
====================================================
  Files                        ?      165           
  Lines                        ?    13129           
  Branches                     ?     2452           
====================================================
  Hits                         ?     6607           
  Misses                       ?     5862           
  Partials                     ?      660           
Flag Coverage Δ
CLI 13.77% <0.00%> (?)
EXAMPLES 80.28% <0.00%> (?)
LANG 54.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yliuuuu yliuuuu marked this pull request as ready for review February 5, 2024 18:37
@yliuuuu yliuuuu requested a review from rchowell February 5, 2024 19:05
@rchowell rchowell merged commit 5fdc88e into partiql-spi-merge Feb 5, 2024
10 checks passed
@rchowell rchowell deleted the partiql-spi-merge-review branch February 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants