Fixes aggregations of attribute references to values of union types #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (92cc57a) but now fail: 0 Number failing in Base (92cc57a) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
=========================================
Coverage 73.14% 73.14%
Complexity 2393 2393
=========================================
Files 247 247
Lines 17623 17623
Branches 3176 3176
=========================================
Hits 12890 12890
Misses 3856 3856
Partials 877 877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
force-pushed
the
fix-count-agg
branch
from
1a8065e to
9084f54
Compare
johnedquinn
force-pushed
the
fix-count-agg
branch
4 times, most recently
from
6cac376 to
91443cd
Compare
RCHowell
requested changes
Mar 29, 2024
partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/PlanTransform.kt
Outdated
Show resolved
Hide resolved
| override fun visitRelOpAggregateCall(node: Rel.Op.Aggregate.Call, ctx: ProblemCallback): org.partiql.plan.Rel.Op.Aggregate.Call { | ||
| val agg = when (val agg = node.agg) { | ||
| is Agg.Unresolved -> { | ||
| val name = agg.identifier.toNormalizedString() |
There was a problem hiding this comment.
For error messaging, perhaps we leave the casing "as-is"
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/PlanTyper.kt
Outdated
Show resolved
Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/PlanTyper.kt
Outdated
Show resolved
Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/TypeEnv.kt
Outdated
Show resolved
Hide resolved
johnedquinn
force-pushed
the
fix-count-agg
branch
from
0d6769c to
d767d08
Compare
RCHowell
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
TypeEnv, we would assert, when looking up an attribute on a value, that the value were aStructType-- even though it could be a union of StructTypes. Or a union of other types. This PR handles this scenario.Open Questions (Not addressed in this PR)
AVGreturn? I've pasted a snippet from SQL:1999 which shows that we are conformant, however, I'm not sold.Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.