run apiDump

[yliuuuu]

Relevant Issues

• [Closes/Related To] Issue #XXX

Description

• Running ./gradlew apiDump to fix build.

Other Information

• Updated Unreleased Section in CHANGELOG: [YES/NO]

  • < If NO, why? >

• Any backward-incompatible changes? [YES/NO]

  • < If YES, why? >
  • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
    errors for users that are using our public APIs or the entities that have public visibility in our code-base. >

• Any new external dependencies? [YES/NO]

  • < If YES, which ones and why? >
  • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >

• Do your changes comply with the Contributing Guidelines
  and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[yliuuuu]

One observation is the that API dumps captures changes in ANTLR generated files. It would be nice to filter out those.

Perhaps we want to:

1. package ANTRL code in an package called xxx.internal.antlr
2. filter out anything source under internal package when running apiDump

[github-actions]

Conformance comparison report-Cross Engine

	Base (legacy)	eval	+/-
% Passing	92.51%	90.67%	-1.84%
✅ Passing	5382	5276	-106
❌ Failing	436	543	107
🔶 Ignored	0	0	0
Total Tests	5818	5819	1
Number passing in both: 5071

Number failing in both: 231

Number passing in legacy engine but fail in eval engine: 312

Number failing in legacy engine but pass in eval engine: 205
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
205 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

	Base (abfc58d)	2a044a7	+/-
% Passing	92.51%	92.51%	0.00%
✅ Passing	5382	5382	0
❌ Failing	436	436	0
🔶 Ignored	0	0	0
Total Tests	5818	5818	0
Number passing in both: 5382

Number failing in both: 436

Number passing in Base (abfc58d) but now fail: 0

Number failing in Base (abfc58d) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

	Base (abfc58d)	2a044a7	+/-
% Passing	90.67%	90.67%	0.00%
✅ Passing	5276	5276	0
❌ Failing	543	543	0
🔶 Ignored	0	0	0
Total Tests	5819	5819	0
Number passing in both: 5276

Number failing in both: 543

Number passing in Base (abfc58d) but now fail: 1

Number failing in Base (abfc58d) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see

• Example 6 — Value Coercion, compileOption: LEGACY

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see

• Example 6 — Value Coercion, compileOption: LEGACY

[alancai98]

One observation is the that API dumps captures changes in ANTLR generated files. It would be nice to filter out those.

Perhaps we want to:

1. package ANTRL code in an package called xxx.internal.antlr
2. filter out anything source under internal package when running apiDump

Agree that it'll be good to do both of those.

1. is tracked in Internalize ANTLR-generated parser sources #1446.
2. we should do as part of the package audit process before v1. For reference, the compatibility checker gradle plugin is pretty easy to configure to ignore certain class paths -- https://github.com/Kotlin/binary-compatibility-validator#optional-parameters. Let's tackle the filtering/excluding in subsequent PRs.