-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internalize generated ANTLR sources #1452
Conversation
fc0d4f8
to
223a94f
Compare
Conformance comparison report-Cross Engine
Number failing in both: 229 Number passing in legacy engine but fail in eval engine: 312 Number failing in legacy engine but pass in eval engine: 207 Conformance comparison report-Cross Commit-LEGACY
Number failing in both: 436 Number passing in Base (23f6fee) but now fail: 0 Number failing in Base (23f6fee) but now pass: 0 Conformance comparison report-Cross Commit-EVAL
Number failing in both: 541 Number passing in Base (23f6fee) but now fail: 1 Number failing in Base (23f6fee) but now pass: 1 Click here to see
Click here to see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me, just one nit comment.
partiql-parser/src/main/kotlin/org/partiql/parser/internal/PartiQLParserDefault.kt
Outdated
Show resolved
Hide resolved
77b9c07
to
d5805ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
Relevant Issues
Description
internal
namespaceinternal
namespacepartiql-parser
README that the ANTLR-generated sources are not to be used outside of code within this package.Other Information
Updated Unreleased Section in CHANGELOG: [NO]
Any backward-incompatible changes? [YES]
public
ANTLR-generated sources under theinternal
namespace. We did not intend for these be used by external consumers ofpartiql-parser
.Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.