Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize generated ANTLR sources #1452

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

alancai98
Copy link
Member

Relevant Issues

Description

  • Moves ANTLR-generated sources under internal namespace
    • Updates corresponding code
  • Adds filter to API compatibility checker to exclude code under internal namespace
  • Adds a comment to partiql-parser README that the ANTLR-generated sources are not to be used outside of code within this package.

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No, on v1 branch.
  • Any backward-incompatible changes? [YES]

    • Moves the public ANTLR-generated sources under the internal namespace. We did not intend for these be used by external consumers of partiql-parser.
  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Apr 30, 2024
@alancai98 alancai98 changed the base branch from main to v1 April 30, 2024 20:56
@alancai98 alancai98 force-pushed the internalize-antlr-sources branch from fc0d4f8 to 223a94f Compare April 30, 2024 20:57
Copy link

github-actions bot commented Apr 30, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.51% 90.70% -1.80%
✅ Passing 5382 5278 -104
❌ Failing 436 541 105
🔶 Ignored 0 0 0
Total Tests 5818 5819 1
Number passing in both: 5071

Number failing in both: 229

Number passing in legacy engine but fail in eval engine: 312

Number failing in legacy engine but pass in eval engine: 207
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
207 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (23f6fee) 4219bb3 +/-
% Passing 92.51% 92.51% 0.00%
✅ Passing 5382 5382 0
❌ Failing 436 436 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5382

Number failing in both: 436

Number passing in Base (23f6fee) but now fail: 0

Number failing in Base (23f6fee) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (23f6fee) 4219bb3 +/-
% Passing 90.70% 90.70% 0.00%
✅ Passing 5278 5278 0
❌ Failing 541 541 0
🔶 Ignored 0 0 0
Total Tests 5819 5819 0
Number passing in both: 5278

Number failing in both: 541

Number passing in Base (23f6fee) but now fail: 1

Number failing in Base (23f6fee) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

Copy link
Contributor

@yliuuuu yliuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, just one nit comment.

@alancai98 alancai98 requested a review from yliuuuu May 1, 2024 18:56
@alancai98 alancai98 force-pushed the internalize-antlr-sources branch from 77b9c07 to d5805ff Compare May 1, 2024 22:41
Copy link
Contributor

@yliuuuu yliuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@alancai98 alancai98 merged commit 28edbb7 into v1 May 2, 2024
14 checks passed
@alancai98 alancai98 deleted the internalize-antlr-sources branch May 2, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internalize ANTLR-generated parser sources
2 participants